Skip to content

Remove emulator preference caching behavior per session #4626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 12, 2025

Conversation

MicroFish91
Copy link
Contributor

No description provided.

@MicroFish91 MicroFish91 requested a review from a team as a code owner August 5, 2025 20:26
@nturinski
Copy link
Member

Can you elaborate what issue this is solving? Was this feedback from Lily or Philip?

@MicroFish91
Copy link
Contributor Author

MicroFish91 commented Aug 6, 2025

Actually let me revisit this, I think I need to make a different change here than I originally thought. I think I interpreted the feedback wrong, but it was from Phillip. I'll add it here for reference after I update

@MicroFish91 MicroFish91 marked this pull request as draft August 6, 2025 17:37
@MicroFish91 MicroFish91 changed the title Cache DTS emulator preferences against unique workspace projects Remove emulator preference caching behavior per session Aug 12, 2025
@MicroFish91
Copy link
Contributor Author

Discussed offline, let's bookmark this and come back to it in the next release, where we can come up with a more robust solution. For this release, we discussed just shipping without any session caching behavior.

@MicroFish91 MicroFish91 marked this pull request as ready for review August 12, 2025 17:47
@MicroFish91 MicroFish91 enabled auto-merge (squash) August 12, 2025 17:48
@MicroFish91 MicroFish91 merged commit bc90b46 into main Aug 12, 2025
2 checks passed
@MicroFish91 MicroFish91 deleted the mwf/fine-yellow branch August 12, 2025 17:49
@MicroFish91 MicroFish91 restored the mwf/fine-yellow branch August 12, 2025 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants